🎨 Fix/enh: Avoid duplicated port compatibility calls #7803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
changed the title
odeimaiz
requested review from
GitHK,
Copilot,
matusdrobuliak66,
pcrespov and
sanderegg
odeimaiz
added
t:enhancement
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a promise-based cache for port compatibility requests to avoid duplicate network calls when checking port compatibility between services.
- Switch calls to use the singleton instance method
getCompatibleInputs - Add
getCompatibleInputsmember inResources.jswith in-memory and persisted caching - Remove the old static
getCompatibleInputsand helper URL builder
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/utils/Ports.js | Updated to call getInstance().getCompatibleInputs instead of the static method |
| services/static-webserver/client/source/class/osparc/form/renderer/PropForm.js | Updated to call getInstance().getCompatibleInputs instead of the static method |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Added new instance getCompatibleInputs with a promise cache and removed the old static implementation |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/data/Resources.js:1433
- [nitpick] The property name
__portsCompatibilityPromisesCachedis very long and uses double underscores. Consider renaming it to something clearer like_pendingPortsCompatibilityRequeststo improve readability.
__portsCompatibilityPromisesCached: null,
services/static-webserver/client/source/class/osparc/data/Resources.js:1729
- The new caching behavior isn't covered by existing tests. Add unit or integration tests to verify that (1) repeated calls with the same parameters return the cached result without making additional requests, and (2) different parameters still fetch new data.
getCompatibleInputs: function(node1, portId1, node2) {
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 3b558ec |
sanderegg
approved these changes
Jun 3, 2025
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
already looking forward to all this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In the same spirit as #7802, this PR avoids duplicated port compatibility calls by keeping a promises cache.
Before:
After:
Related issue/s
How to test
Dev-ops